Refactor Testing Commands

defenseunicorns / uds-cli

Apache License 2.0

24 stars 10 forks source link

Refactor Testing Commands #782

Closed UncleGedd closed 1 week ago

UncleGedd commented 1 month ago

Describe what should be investigated or refactored

Today in our e2e tests we are using dedicated functions that wrap UDS commands (ie. deploy(), devDeploy(), devDeployPackages(), etc).

In a separate PR the runCmd function was introduced which is a generic way to pass in UDS Commands. Discuss refactoring our test suite to remove the individual functions in favor of runCmd

TristanHoladay commented 1 month ago

I like runCmd because you can very clearly see the details of the cli command that will execute, but after converting a few tests i'm wondering if that quick transparency is worth the redundant code and clutter that i think it brings.

Maybe it's better for those one off cases that the generic commands don't allow for?

Screenshot from 2024-07-16 08-08-03

UncleGedd commented 1 month ago

My 2 cents:

Having runCmd saves me from having to click into those dedicated testing functions
Agreed runCmd is sort of redundant, but so is creating the same create command with multiple flags

Thoughts @decleaver ?