defenseunicorns / uds-package-gitlab

🏭 UDS GitLab Zarf Package
Apache License 2.0
5 stars 3 forks source link

Deploy does not wait on `Package` CR readiness #140

Closed mjnagel closed 1 month ago

mjnagel commented 1 month ago

Environment

N/A - not environment specific, but encountered on RKE2.

Steps to reproduce

  1. Deploy with a known bad Package configuration (example: add an erroneous client scope)
  2. Watch gitlab deploys "happily".

Expected result

Deployment should fail if Package CR is not ready.

Actual Result

Since helm/zarf do not wait on the Package, and there is no action in the zarf.yaml to wait on it, it's status is ignored for the deployment.

Severity/Priority

Low/Medium

Additional Context

In uds-core we added onDeploy.after actions to most packages to validate they are fully healthy before proceeding, example - https://github.com/defenseunicorns/uds-core/blob/main/src/grafana/common/zarf.yaml#L21-L31. Unsure, but expect this is an issue on other SWF repos as well.