defenseunicorns / uds-package-gitlab

🏭 UDS GitLab Zarf Package
Apache License 2.0
6 stars 3 forks source link

fix: add working podmonitor for sidekiq #169

Closed zachariahmiller closed 1 month ago

zachariahmiller commented 1 month ago

Description

Related Issue

Fixes # https://github.com/defenseunicorns/uds-package-gitlab/issues/165

Type of change

Checklist before merging

zachariahmiller commented 1 month ago

I put this in draft because while the deployment will work fine and doesnt impact existing functionality (this pod monitor is not there/working currently), a patch is required to uds-core to not overwrite the scrapeClass when its explicitly defined in a PodMonitor resource, which we had to do in this case to enable the enableHTTP2: false that was required for sidekiq but not exposed in the Package CR.

All that to say it could be merged right now and then the functionality "works" in the next uds-core patch release.

Anyways, visual proof of the active target in prometheus after deploying gitlab against a uds-core build based on the linked PR branch: image