search

defenseunicorns / uds-package-gitlab

🏭 UDS GitLab Zarf Package
Apache License 2.0
6 stars 3 forks source link

Update repo to utilize workflows, actions and tasks from the uds-common repo #39

Closed zachariahmiller closed 6 months ago

zachariahmiller commented 6 months ago

Describe what should be investigated or refactored

We created a repo to enable reuse of common uds tasks, gh actions and gh workflows. This repo should be updated to utilize the common ones where possible.

Links to any relevant code

https://github.com/defenseunicorns/uds-common

Additional context

Any questions just ask.

ericwyles commented 6 months ago

I'm picking this one up.

ericwyles commented 6 months ago

@zachariahmiller I changed to the uds-common setup action, but that action is missing Zarf and node.js setup steps. Do you think we want to add those to the uds-common setup? (you can see in my draft PR CI is failing because Zarf is not found.)

zachariahmiller commented 6 months ago

@ericwyles FYSA Closing this issue because it is completed. I guess moving it to done on the board does not complete it. Usually my issues auto-complete when i merge the associated pr after I create them from the issue. Not immediately clear what was done differently here so that made that not work.

ericwyles commented 6 months ago

@zachariahmiller Thanks. I was thinking moving it on the board would close it. I'll try to notice next time if I missed an option on PR merge that should have closed it.