feat: implement oidc sso for gitlab

defenseunicorns / uds-package-gitlab

🏭 UDS GitLab Zarf Package

Apache License 2.0

6 stars 3 forks source link

feat: implement oidc sso for gitlab #61

Closed corang closed 6 months ago

corang commented 6 months ago

Description

barebones sso implementation using oidc

Related Issue

Closes #60

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Other (security config, docs update, etc)

Checklist before merging

[x] Test, docs, adr added or updated as needed
[x] Contributor Guide Steps followed

zachariahmiller commented 6 months ago

Also, since our main versioning tracks app version intentionally, while this is a feature technically feat: will actually force me to do a manual release if this gets merged. Technically we would want chore or something to just bump the uds.x part of the version. This is kind of frustrating as it stands today i either have the manually edit the whole release because you make an accurate semantic commit or this shows up somewhat inaccurately as a "chore" in changelog

mjnagel commented 6 months ago

@zachariahmiller in theory you should be able to affect that during the squash merge of this PR (adding Release As: <whatever>) in that. Very much in theory though, so do what is less pain inducing.

zachariahmiller commented 6 months ago

@corang Also if the deployment is working locally for you let me know and i'll try to help debug the CI failures

corang commented 6 months ago

still need to test sso locally, will update when I know it works

corang commented 6 months ago

SSO confrmed working locally