search

defenseunicorns / uds-package-sonarqube

🏭 UDS Sonarqube Zarf Package
Apache License 2.0
3 stars 2 forks source link

feat: set architecture only on registry1 flavor #31

Closed MxNxPx closed 4 months ago

mjnagel commented 5 months ago

I don't think this is overly important but in thinking this through this would result in a weird behavior if someone on an ARM machine attempts to create the registry1 flavor. The result would be a successful build with an empty zarf package (no components). It could cause confusion if they go to deploy it or the test bundle and see nothing happen.

Not sure if we already call this out but it would be good to note somewhere in the readme that the flavor registry1 is only functional on amd64 machines due to image restrictions.

zachariahmiller commented 5 months ago

I don't think this is overly important but in thinking this through this would result in a weird behavior if someone on an ARM machine attempts to create the registry1 flavor. The result would be a successful build with an empty zarf package (no components). It could cause confusion if they go to deploy it or the test bundle and see nothing happen.

Not sure if we already call this out but it would be good to note somewhere in the readme that the flavor registry1 is only functional on amd64 machines due to image restrictions.

Agreed thats confusing and should be reflected in the docs. Doing this change was also recommended by @Racer159 and I am in the process of adding it to the gitlab repo.

mjnagel commented 5 months ago

If we really wanted to we could do an only registry1/arm64 component that runs an oncreate action to fail the build 😆. Ideally folks are just consuming the published package so it's probably overkill...but it's an option...

zachariahmiller commented 5 months ago

Just circling back on this since the approval is pretty old... Are we all still in alignment on this?

A note in the readme would be nice on the amd64 limitation for registry1, but otherwise i think this is good to go.