search

defenseunicorns / uds-package-sonarqube

🏭 UDS Sonarqube Zarf Package
Apache License 2.0
3 stars 2 forks source link

Investigate Updating Upstream SonarQube Helm Chart to not require hostname/wget #48

Closed ericwyles closed 1 month ago

ericwyles commented 4 months ago

Describe what should be investigated or refactored

This package is currently using the registry1 chart because the upstream chart depends on 'hostname' and 'wget' to be available in the images for liveness/readiness, but registry1 images do not include those tools.

We need to investigate making a PR to upstream sonarqube to allow us to do liveness/readiness without needing those tools so we can use upstream chart.

Links to any relevant code

https://github.com/SonarSource/helm-chart-sonarqube/blob/215917e05bef37fbb930e9201bcbb6649a49399e/charts/sonarqube/templates/deployment.yaml#L296

Additional context

When trying to use registry1 images with upstream chart, liveness probe failes with this message Message: Liveness probe failed: sh: line 1: hostname: command not found

ericwyles commented 2 months ago

Started a conversation here: https://community.sonarsource.com/t/helm-chart-probes-issue-with-hardened-container-images-no-wget/114377

ericwyles commented 1 month ago

No answer on the conversation so submitted a PR: https://github.com/SonarSource/helm-chart-sonarqube/pull/481

If that goes through we can override the probes like this in registry1-values.yaml which is equal behavior to what the repo1 chart does now:

livenessProbe:
  exec: null
  httpGet:
    path: /
    scheme: HTTP
    port: 9000
readinessProbe:
  exec: null
  httpGet:
    path: /api/system/status
    scheme: HTTP
    port: 9000
ericwyles commented 1 month ago

Added a new issue to track migration to the upstream chart now that my change is merged. https://github.com/defenseunicorns/uds-package-sonarqube/issues/82