search

defeo / jupyterhub-docker

A configuration for a JupyterHub+DockerSpawner+CASAuthenticator server with Traefik proxy, based on docker-compose
https://opendreamkit.org/2018/10/17/jupyterhub-docker/
MIT License
201 stars 112 forks source link

rename env variable #1

Closed selloween closed 5 years ago

selloween commented 5 years ago

Hi!

First of all thank you for the awesome setup.

I changed the env variable DOCKER_JUPYTER_CONTAINER to DOCKER_JUPYTER_IMAGE as defined in the docker-compose.yml

Cheers,

Selwyn

jamesdbrock commented 5 years ago

The docker-compose.yml says DOCKER_JUPYTER_CONTAINER I think?

https://github.com/defeo/jupyterhub-docker/blob/d2e20a3fa1a899b9f9cd8e8de17597d679a0786e/docker-compose.yml#L12

DOCKER_JUPYTER_IMAGE is a better name though.

defeo commented 5 years ago

Thanks for the suggestion. Indeed this change must be reflected in docker-compose.yml for things to keep working.

selloween commented 5 years ago

I did not notice that DOCKER_JUPYTER_CONTAINER is set in docker-compose.yml. I followed your tutorial https://opendreamkit.org/2018/10/17/jupyterhub-docker/ where the variable is named DOCKER_JUPYTER_IMAGE and got things mixed up.