search

deferpanic / goweave

Aspect Oriented Programming for Go
MIT License
225 stars 9 forks source link

support windows and modify function's arguments' type check algorithm #8

Closed yaozijian closed 9 years ago

yaozijian commented 9 years ago

1 Add support of Windows 2 Modify the function's argument type compare algorithm (in function "containeArgs" at weave/ast.go) check function's every argument,include the arguments not use package.

For example: func blah(a, b string, x int) error { fmt.Println(strconv.Itoa(x)) return nil }

and the weave file: aspect { pointcut: execute(blah(string,string,int) int) advice: { before: { fmt.Println("call blah: x=",x) } } }

eyberg commented 9 years ago

hi @yaozijian ! thanks for the contribution - windows support would be great!

1) would you mind getting the tests to pass first?

2) I think you can prob. cp weave/build_linux.go to weave/build_darwin.go