search

defi-wonderland / natspec-smells

👃Automatically identify missing or incomplete natspec
MIT License
90 stars 7 forks source link

Support solidity 0.8.25 #50

Closed beeb closed 3 months ago

beeb commented 3 months ago

Would it be possible to update the version of solc-typed-ast so that we can use solidity 0.8.25?

I understand that solc-typed-ast has not yet released a new version for solidity 0.8.26 but it would be already good to support 25.

gas1cent commented 3 months ago

Hey @beeb, thanks for the reminder! The PR is waiting for a review. I'll release the new version in a couple of hours.

beeb commented 3 months ago

That was fast! 😄 Thanks a lot

gas1cent commented 3 months ago

@beeb done ser, please try v1.1.2 and let us know if you need anything else.

beeb commented 3 months ago

Seems like the package still depends on the outdated version

https://github.com/defi-wonderland/natspec-smells/blob/a7e47bca42799863fb6b13f04996cdb9240099ff/package.json#L31

It should read 18.1.6

gas1cent commented 3 months ago

My bad! The change must have gotten lost in the branch-switching shenanigans. We'll fix that asap.

gas1cent commented 3 months ago

@beeb please check out v1.1.3, it supports Solidity 0.8.25

beeb commented 3 months ago

All good now! thanks