defi-wonderland / smock

The Solidity mocking library
MIT License
319 stars 40 forks source link

feat request: edit multiple variables at once #111

Closed tonykogias closed 2 years ago

tonykogias commented 2 years ago

Is your feature request related to a problem? Please describe. If someone wants to edit more than one variable using a mock contract, the user would have to repeat using the setVariable function. I believe it would help if there was a function that would edit multiple variables at once (like smock's v1 smodify.put)

wei3erHase commented 2 years ago

hi @tonykogias, thanks for the issue AND the PR #112 , i've made some comments on it, and we're actually establishing a bounty for it so keep tuned i'm leaving this issue open until there's a closure with the task, bests!

wei3erHase commented 2 years ago

Bounty for this task has been set! 💰

tonykogias commented 2 years ago

Hey @wei3erHase! Thanks for the comments I will look into it later today and make the changes. I really appreciate the bounty that was added as well! Cheers :)

0xGorilla commented 2 years ago

In order to complete the task:

0xGorilla commented 2 years ago

@tonykogias please add your address to the issue in dework so we can send you the bounty 🥳

tonykogias commented 2 years ago

@tonykogias please add your address to the issue in dework so we can send you the bounty 🥳

I have linked my metamask account to my profile, is there something else I have to do? Should I send you my address here? I am not that used to dework.

0xGorilla commented 2 years ago

Sent the 200 USDC your way! Thanks a lot for your contribution @tonykogias

There are lots of other issues if you want to continue helping Smock ❤️

tonykogias commented 2 years ago

Thanks! I appreciate it I will definitely have a look at those issues.