defi-wonderland / smock

The Solidity mocking library
MIT License
321 stars 40 forks source link

The feature reverting with message is not working yet #177

Open kalloc opened 1 year ago

kalloc commented 1 year ago

Describe the bug

Sometimes, I need to make fake revert. For example, when I write tests for uniswap family contracts or another contracts based on nested calls. But I can't make fake revert with custom message using smock. Please, help me to understand what I did wrong.

Reproduction steps

To simplify reproduction, I made a repo https://github.com/kalloc/smock-reverts-bug

Expected behavior I expected to have an ability to fake revert with custom message

Screenshots

image

System Specs:

0xmichalis commented 2 weeks ago

This is quite limiting as we cannot unit test error handling of external calls.