search

defichain-api / masternode-health-server

Server part to send data to the masternode-health-api
MIT License
2 stars 4 forks source link

defi.conf md5 hash #19

Closed adrian-schnell closed 3 years ago

adrian-schnell commented 3 years ago

To recognize possible unwanted modifications on the defi.conf file, we should add the md5 hash of this file to the API calls.

what do you think about this @sandrich @DerFuchs ?

sandrich commented 3 years ago

Should be easy to implement. Do you think we should store the old hash locally as well or just send it to the api?

adrian-schnell commented 3 years ago

think we could do both..

  1. storing it tmp on the server and only send a flag "conf_md5_changed" to the api
  2. sending it all the time to the API - so the API server is responsible to detect the md5 hash change

at the moment I'm not sure what's better... maybe let's keep all the logic on the API server..?

sandrich commented 3 years ago

@adrian-schnell alerting is part of the api service I think so the logic should be there really.