search

defichain-api / masternode-health-server

Server part to send data to the masternode-health-api
MIT License
3 stars 4 forks source link

Accept rpcauth in defi.conf #37

Open sandrich opened 2 years ago

sandrich commented 2 years ago

We should acccept rpcauth inside the defi.conf since rpcuser and rpcpassword are being deprecated

adrian-schnell commented 2 years ago

does it make sense to support both, but prefer rpcauth?

sandrich commented 2 years ago

I think we should support both as many still use the old way.

sandrich commented 2 years ago

I was just looking at it. rpcauth contains a HMAC hashed string with a salt. Without the actual password we cannot use rpcauth. Or in other words. If someone has rpcauth defined the person need to provide the rpcpassword via the argument.

Unless someone has a better idea? I think defi-cli uses some sort of an auth cookie but need to investigate this part.