defichain-api / masternode-health-server

Server part to send data to the masternode-health-api
MIT License
2 stars 4 forks source link

Please add important setup steps/parts to readme file #9

Closed DerFuchs closed 3 years ago

DerFuchs commented 3 years ago

To keep things straight and help new users with the setup of Masternode Health, the following information should be added to the readme file:

1) PATH After installation, the script suggests that I should add '/home//.local/bin' to my PATH variable. Either the readme file should contain instructions how to do that or (and that's preferred by me) the application should be installed in a general location, which makes that obsolete.

2) Where to find RPC user and RPC password For running Masternode Health, it is necessary to provide both RPC user and password. Users may not be able to find out these things by themselves.

sandrich commented 3 years ago

Thanks. One issue with general location is that it will mostly require privileged access such as /usr/local/bin/ while the python package can be installed in user space.

One option could be to add a symlink such as

sudo ln -sf ~/.local/bin/masternode-health /usr/local/bin/masternode-health

Still requires privileges but could be explained. The other option is to just use

~/.local/bin/masternode-health xxx

DerFuchs commented 3 years ago

I agree! I am preparing a pull-request, containing some additional information. Hang on a minute ^^

DerFuchs commented 3 years ago

I have created a pull request: https://github.com/defichain-api/masternode-health-server/pull/10