search

defmethodinc / just-not-sorry

Chrome extension that warns you when you write emails using words which undermine your message
https://justnotsorry.com/
Other
243 stars 37 forks source link

Highlighting issues #117 investigation #130

Closed jduffy3 closed 3 years ago

jduffy3 commented 3 years ago

I verified things are still working on outlook and gmail.

I don't think performance has taken a hit either. I've tried to compare before and after the fix in place and haven't noticed much differences I was using issue #110 as an example.

For the fix I added a check to see if the target html element contains any child nodes and to check those for pattern matches, else just check the node itself.

The reason I added this is when investigating the DOM of an email the text was wrapped in their own self contained divs. When we look for a pattern match textContent appears to return a "textified" version of this by converting them to \n and returning the entire contents as one string which then fails the entire parser.

jduffy3 commented 3 years ago

@sbrudz friendly reminder. Hopefully I've resolved issues you've raised. 😄

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.0.0-beta.10 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.1.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: