search

defmethodinc / just-not-sorry

Chrome extension that warns you when you write emails using words which undermine your message
https://justnotsorry.com/
Other
243 stars 37 forks source link

Fix underline positioning on outlook.com #135

Closed sbrudz closed 3 years ago

sbrudz commented 3 years ago

This fixes an issue with the underlines in emails on outlook.com appearing above the words.

The root cause was that outlook.com changed the DOM structure, adding padding to the contenteditable div that was the normal parent as well as adding another containing div with no position attribute to the hierarchy. The new intermediate was being used as the parent for calculating coords but the coords of the words were relative to the contenteditable div. Using offsetParent instead of parentNode skips the intermediate div and makes things line up properly.

Fixes #134

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 2.0.0-beta.12 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.1.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: