defmethodinc / just-not-sorry

Chrome extension that warns you when you write emails using words which undermine your message
https://justnotsorry.com/
Other
243 stars 37 forks source link

Error on outlook.office.com #141

Closed sbrudz closed 2 years ago

sbrudz commented 2 years ago

While testing on outlook.office.com, Tami got the following error: image

It seems that it happened once I opened an email not in the main pane but in the modal that shows up if theres an attachment that you are previewing. But when I did the same thing (opened another email with a different attachment), nothing happened.

The first attachment was an excel document.

This is the last known issue blocking full public release of v2.1.

tamireiss commented 2 years ago

To be clear, I think we can release if this isn’t resolved easily and quickly. The user doesn’t experience anything and I only noticed the errors because I’m in developer mode on the extensions page.

-Tami @tamireiss / tamireiss.com ( http://tamireiss.com )

Sent via Superhuman iOS ( @.*** )

On Tue, Jan 11 2022 at 8:00 AM, Steve Brudz < @.*** > wrote:

While testing on outlook.office.com, Tami got the following error: image ( https://user-images.githubusercontent.com/1520763/148942016-ea766062-bca3-46e0-997a-b9cc489cf905.png )

It seems that it happened once I opened an email not in the main pane but in the modal that shows up if theres an attachment that you are previewing. But when I did the same thing (opened another email with a different attachment), nothing happened.

The first attachment was an excel document.

This is the last known issue blocking full public release of v2.1.

— Reply to this email directly, view it on GitHub ( https://github.com/defmethodinc/just-not-sorry/issues/141 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAMWI55FTHZ42N2VBKOGRNLUVQSVTANCNFSM5LWH33EQ ). Triage notifications on the go with GitHub Mobile for iOS ( https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 ) or Android ( https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub ). You are receiving this because you are subscribed to this thread. Message ID: <defmethodinc/just-not-sorry/issues/141 @ github. com>

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.1.0-beta.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

sbrudz commented 2 years ago

@tamireiss That's good to know. The fix was easy, so hopefully the release above resolves the issue and we can release.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.1.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 2.3.1-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: