Upgrade to manifest v3 - Githubissues

defmethodinc / just-not-sorry

Chrome extension that warns you when you write emails using words which undermine your message

https://justnotsorry.com/

Other

243 stars 37 forks source link

Closed sbrudz closed 2 years ago

sbrudz commented 2 years ago

Upgrade JustNotSorry to use v3 of the web extension manifest
Remove the custom user installation Google Analytics event, allowing us to reduce the scope of the permissions needed by the extension. We already get install events reported to google analytics via the Chrome Web Store, so we shouldn't miss this data.
Remove the declarativeContent permission because the content_scripts in the manifest already provide permissions for these sites.

Fixes #159

yutingcxiang commented 2 years ago

Changes look good and had no issues running it locally. Seems like the branch is out ofd date?

sbrudz commented 2 years ago

Thank you for reviewing! I'll update the branch.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 2.4.0-beta.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: