search

defmethodinc / just-not-sorry

Chrome extension that warns you when you write emails using words which undermine your message
https://justnotsorry.com/
Other
243 stars 37 forks source link

Refactor/cleanup jns #183

Closed jduffy3 closed 1 year ago

jduffy3 commented 1 year ago

These refactorings improve the clarity of the code. Great work!

Also, performance on long emails with many warnings is much better now.

While testing, I noticed that the tooltip has a lower z index than the subject line: image

I wasn't able to reproduce unless I hardcoded the position, but I tried removing the setting of that variable and I think the placement is better. Could you try on your machine and see if that fixes it?

sbrudz commented 1 year ago

I wasn't able to reproduce unless I hardcoded the position, but I tried removing the setting of that variable and I think the placement is better. Could you try on your machine and see if that fixes it?

I pulled down the new code and restarted my local environment. Now I can't reproduce it anymore. The warnings always display below the underline when close to the top. Let's call this issue fixed.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.5.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: