search

defmethodinc / just-not-sorry

Chrome extension that warns you when you write emails using words which undermine your message
https://justnotsorry.com/
Other
242 stars 37 forks source link

Go beyond GMail? Internet forms. #4

Open cmrberry opened 8 years ago

cmrberry commented 8 years ago

This is an awesome idea, thanks for your work on it so far!

Any plans to enable this on things other than GMail?

Like, say, GitHub Issues? :smile:

tami-cyrus commented 8 years ago

We opensourced it so that other people could make more tools if they wanted to. Chances are we'll hit iOS and Android native mail clients next.

Tami Reiss CEO Cyrus Innovation http://www.cyrusinnovation.com/ 212-647-7186

Agile Reinforcement to accelerate your development

Dedicated to respect and diversity

@tamireiss / @cyrusinnovation

Learn about the difference between the Cyrus way http://www.cyrusinnovation.com/differences-between-xp-vs-scrum-agile/ and other consultancies.

On Tue, Dec 29, 2015 at 4:17 PM, Rachel Berry notifications@github.com wrote:

This is an awesome idea, thanks for your work on it so far!

Any plans to enable this on things other than GMail?

Like, say, GitHub Issues? [image: :smile:]

— Reply to this email directly or view it on GitHub https://github.com/cyrusinnovation/just-not-sorry/issues/4.

jared-di commented 8 years ago

Just tried to use this, but I'm using Inbox, not Gmail. Can this be extended to include Inbox as most people have made the switch? Thanks, Jared.

tami-cyrus commented 8 years ago

We opensourced it so that other people could make more tools if they wanted to. Chances are we'll hit iOS and Android native mail clients next.

Tami Reiss CEO Cyrus Innovation http://www.cyrusinnovation.com/ 212-647-7186

Agile Reinforcement to accelerate your development

Dedicated to respect and diversity

@tamireiss / @cyrusinnovation

Learn about the difference between the Cyrus way http://www.cyrusinnovation.com/differences-between-xp-vs-scrum-agile/ and other consultancies.

On Wed, Dec 30, 2015 at 6:22 PM, jared-di notifications@github.com wrote:

Just tried to use this, but I'm using Inbox, not Gmail. Can this be extended to include Inbox as most people have made the switch? Thanks, Jared.

— Reply to this email directly or view it on GitHub https://github.com/cyrusinnovation/just-not-sorry/issues/4#issuecomment-168094150 .

GForceWeb commented 8 years ago

+1 for expanding the reach of the plugin to all form fields in chrome (like grammarly) and not just gmail. I use the gmail inbox client which is unsupported by this by default.

tami-cyrus commented 8 years ago

We're excited that you want to use Just Not Sorry. The plans for what comes next haven't been decided yet. We have a lot of requests to build something similar for Outlook and Mobile. If we figure out the most user friendly way to do mobile, that should help with inbox a little bit.

Additionally, we open sourced the code so if anyone else wanted to expand it for Inbox, they could. We'll keep you posted whatever direction is chosen.

Happy new year!

Tami Reiss CEO http://www.cyrusinnovation.com/ @tamireiss 212-647-7186 Agile reinforcement to accelerate your development Best place in NYC for female founders to build great products

Sent from a device smarter than a third grader, but with equally bad spelling habits.

On Jan 2, 2016, at 5:26 AM, Grant notifications@github.com wrote:

+1 for expanding the reach of the plugin to all form fields in chrome (like grammarly) and not just gmail. I use the gmail inbox client which is unsupported by this by default.

— Reply to this email directly or view it on GitHub.

TheWrongAlice commented 8 years ago

@tami-cyrus so to clarify, if I set up a PR for inbox support, could it be accepted and merged, or would you rather have it published separately?

tami-cyrus commented 8 years ago

Could be merged.

Tami Reiss CEO http://www.cyrusinnovation.com/ @tamireiss 212-647-7186 Agile reinforcement to accelerate your development Best place in NYC for female founders to build great products

Sent from a device smarter than a third grader, but with equally bad spelling habits.

On Mar 15, 2016, at 9:31 AM, Alice Cyan Carlsson notifications@github.com wrote:

@tami-cyrus so to clarify, if I set up a PR for inbox support, could it be accepted and merged, or would you rather have it published separately?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/cyrusinnovation/just-not-sorry/issues/4#issuecomment-196818679

sbrudz commented 8 years ago

@TheWrongAlice I'm organizing the roadmap for JustNotSorry and since Inbox support is one of our top requested features, I'd like to line it up for the next major release. Have you had a chance to work on a PR? If you have work in progress, I'm happy to review the PR or discuss design ideas.

TheWrongAlice commented 8 years ago

I have not had the chance to start

On Tue, Apr 5, 2016 at 4:59 AM Steve Brudz notifications@github.com wrote:

@TheWrongAlice https://github.com/TheWrongAlice I'm organizing the roadmap for JustNotSorry and since Inbox support is one of our top requested features, I'd like to line it up for the next major release. Have you had a chance to work on a PR? If you have work in progress, I'm happy to review the PR or discuss design ideas.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/cyrusinnovation/just-not-sorry/issues/4#issuecomment-205619844

sbrudz commented 8 years ago

No worries. I had an idea over the weekend for how to do it using mutation observers. It may or may not work. I'll try a spike on it this week.

sbrudz commented 8 years ago

@kwokster10 Per our conversation, here's the experiment that I started a5dec2c59a5f4db8688ca0d406aced71dad3aa23 It uses a DOM Mutation observer to look for DIVs marked contenteditable and then applies the JustNotSorry warning checker to it. It doesn't quite work yet but it's a start. In theory, the approach should work for any web page -- inbox, github issues, hotmail. It would also allow us to get rid of the dependencies on jQuery and Gmail.js. My worries about the approach are that it might negatively impact performance or use up a lot of memory.

rocketinventor commented 7 years ago

@sbrudz Yah, mutation observer is bad for performance. There are other third-party grammar checkers out there for chrome that work everywhere. I wonder how they work.

sbrudz commented 3 years ago

Here's an update on where we're at with this feature request:

For now, we'll need to add support for new sites on a case by case basis.