defmethodinc / just-not-sorry

Chrome extension that warns you when you write emails using words which undermine your message
https://justnotsorry.com/
Other
243 stars 37 forks source link

Fix underline position and remove Inbox code #60

Closed sbrudz closed 4 years ago

sbrudz commented 4 years ago

This PR focuses on fixing the issues with the position of the underlines for various edge cases, including:

As part of this work, I unified how underline position calculation is done (so compose, reply, and forward all work the same way) and removed the Inbox specific code. The tests all pass now.

There are still two outstanding issues related to underline positioning:

These issues are related to a different area of the code, so I'd like to handle them separately.

@ProfJanetDavis @steveatdm @perfetti Please let me know what you think of the changes. If you'd like any tweaks made to the line position (such as moving it closer to the word), please let me know.

Fixes #54
Fixes #55

ProfJanetDavis commented 4 years ago

Works for me! Thanks, @sbrudz !

steveatdm commented 4 years ago

@sbrudz Looks good, glad we could unify that. Only suggestion is to bring the underline a bit closer to the target text as you mentioned (Opened #61 which would change it from the left representation to the right):

comparison
sbrudz commented 4 years ago

That looks nicer, @steveatdm . Thanks for the PR!