search

defog-ai / sql-eval

Evaluate the accuracy of LLM generated outputs
Apache License 2.0
485 stars 52 forks source link

Simplified if statement logic in compare_df in eval.py; minor refactoring #124

Closed andreped closed 2 months ago

andreped commented 2 months ago

Cool project! As I will be testing the tool in some of my industry applications, it made sense to contribute :]

I noticed some minor issues, which I tried to resolve in this PR.

They should not impact the result, although it may improve runtime by a negligible amount as there were previously being performance some redundant compute. The main reason for this PR is to improve readability.