Fix translation script - Githubissues

wendy-aw commented 2 weeks ago

Previously, schema names could still be found in the instructions of sqlite, mysql, bigquery. Script will now scrub these.
Fixed ddl_to_dialect which had redundant preprocessing that was accidentally removing some column descriptions.
Preserved new lines in translated ddl with the arg pretty=True
Removed schema names from cot_instructions if one of the 3 dialects above.
Also changed model for translation to gpt-4-turbo. Hopefully it can correct the date arithmetic translations in #172
Minor: took the chance to modify a print statement in run_checkpoints_adapters

wendy-aw commented 2 weeks ago

Ahh yesss my bad I forgot about that. That's still there. Working on it now!

rishsriv commented 2 weeks ago

Awesome, thank you! Feel free to just tag me here once you make a push and we can then merge it :D

rishsriv commented 2 weeks ago

I also made a tiny change to the cot prompt!

rishsriv commented 2 weeks ago

Thanks Wendy! Looks good to me. Merging!

defog-ai / sql-eval