defold / editor2-issues

DEPRECATED
44 stars 4 forks source link

Draging a folder with images and atlases in it gives error [DEFEDIT-803] #523

Closed Malmer closed 7 years ago

Malmer commented 7 years ago

Defold version1.2.98
Defold sha6725d7a9bc8fc85b3d6759eb5ed7dfb9df2cf9fb
Build time2017-02-21T10:13:40.438078
OS nameMac OS X
OS version10.12.3
OS archx86_64
Java version1.8.0_102-b14
Errora5fcd39c502b4fabb2c56cb8ec5f2877
matgis-king commented 7 years ago

I'm unable to reproduce this in dev. Here's what I did:

  1. Created a new folder in my project.
  2. Dragged some .png files to it from Finder.
  3. Created an .atlas file in the folder and added the .png files to it.
  4. Added a Sprite to a Game Object in my main.collection that referenced the .atlas file.
  5. Moved the folder containing the .atlas and .png files in the Asset Brower panel.

I repeated step 5 several times, and every time the references to the .atlas and the .png files were updated to the new location. I did not manage to cause the error.

Am I missing a step?

Malmer commented 7 years ago

I have been having lots of issues when moving folders in general in defold. Maybe it has to do with things being in collection proxies? But I got an error moving my images folder and moving my folder with collections and scripts. All of these folders do have multiple subfolders too.

Malmer commented 7 years ago

My folder structure:

assets
  images
    atlas
      myaltas.atlas
    game
      items
        (a bunch of pngs)

Steps:

  1. Create folder named "test"
  2. Drag assets to folder tests
  3. Error
matgis-king commented 7 years ago

I'm still not able to reproduce this using the suggested folder structure inside the same project and editor revision. There must be an earlier step we're missing. I've added some asserts in a PR that might help us track down the cause.

matgis-king commented 7 years ago

Asserts have been merged. Let's close this for now, and create a new issue if any of the asserts trigger.