search

defold / extension-admob

Defold native extension which provides access to AdMob functionality on Android and iOS
https://www.defold.com/extension-admob/
MIT License
37 stars 12 forks source link

Android: banner truncates in landscape orientation #12

Closed alexeyfeskov closed 2 years ago

alexeyfeskov commented 2 years ago

Describe the bug (REQUIRED) Top-positioned banners are truncating in landscape mode on displays with rounded corners (Android 9+ devices : Xiaomi Mi 9 SE and some others) imageimage

To Reproduce (REQUIRED) Steps to reproduce the behavior:

  1. Download lasted release and open with Defold Editor (1.2.185 in my case)
  2. Turn on Dynamic Orientation in game.project
  3. Bundle and install APK on affected device
  4. Load banner and show at admod.POS_TOP_CENTER
  5. Observe: in landscape orientation, the banner is truncated

Expected behavior (REQUIRED) Banner is fully visible

Platforms (REQUIRED):

Additional context (OPTIONAL): I've fix same issue for Applovin Max and will try to port this fix for AdMob

alexeyfeskov commented 2 years ago

I've create PR to fix it. https://github.com/defold/extension-admob/pull/13

AGulev commented 2 years ago

Thank you @alexeyfeskov !!!