defold / extension-fbinstant

Facebook Instant Games extension for the Defold game engine
https://defold.com/extension-fbinstant/
MIT License
38 stars 20 forks source link

The callback for fbinstant.share() doesn't trigger "when the share dialog has been closed" #77

Closed totebo closed 4 years ago

totebo commented 4 years ago

It triggers "success=true" when the share dialog has been opened. This means there is no way of knowing if the user shared or cancelled the share dialogue.

britzl commented 4 years ago

It doesn't look like the Javscript SDK for fbinstant.shareAsync() indicates success either:

https://developers.facebook.com/docs/games/instant-games/sdk/fbinstant6.3

The success = true simply indicates creation of the share dialog was successful or not (ie if the args were ok etc). Not if the user actually shared or cancelled.

totebo commented 4 years ago

Yeah, some strange documentation there. The Facebook docs are wrong:

"the returned promise will resolve when the dialog is closed"

It is resolved after it's been opened (or failed to open).

This one can probably be closed.

britzl commented 4 years ago

Ok, closing