search

defold / extension-ironsource

Defold native extension which provides access to IronSource mediation on Android and iOS
MIT License
10 stars 2 forks source link

Add extension name and version in confiig #16

Closed AGulev closed 1 year ago

AGulev commented 1 year ago

Android: ConfigFile.getConfigFile().setPluginData(pluginType, pluginVersion, pluginFrameworkVersion);

iOS: [ISConfigurations getConfigurations].plugin=@""; // pluginType [ISConfigurations getConfigurations].pluginVersion=@""; // pluginVersion [ISConfigurations getConfigurations].pluginFrameworkVersion=@""; //pluginFrameworkVersion

pluginType - "Defold" pluginVersion - The SDK version of Defold, wrapping iS Native SDK pluginFrameworkVersion - The Defold engine version

AGulev commented 1 year ago

@britzl

pluginVersion - The SDK version of Defold, wrapping iS Native SDK Do you have any ideas how to implement it? Because we decide this version when we release plugin on githubreleases. So I'm not sure what's the best way to implement this.

AGulev commented 1 year ago

Xamarin just puts the version of the native SDK there, which maybe ok if you keep feature set and version number updated: https://developers.is.com/ironsource-mobile/xamarin/get-started-ironsource-xamarin-plugin-ios/#step-2 https://developers.is.com/ironsource-mobile/xamarin/get-started-ironsource-xamarin-plugin-android/#step-1

britzl commented 1 year ago

As long as it is some value which is unique to each release and we can easily figure this out then it doesn't necessarily have to match with the release version on GitHub.

Could we calculate a sha1 somehow? Or could we manually update some value in the source code each time we do a release?

AGulev commented 1 year ago

@britzl I think the easiest way is to specify it manually. There is always a risk to forget to do it, but I think I know how to specify it in one place at least.

AGulev commented 1 year ago

fixed in 0.6.0