search

deforum-art / sd-webui-deforum

Deforum extension for AUTOMATIC1111's Stable Diffusion webui
https://deforum.github.io
Other
2.69k stars 389 forks source link

[Feature Request]: remove 'outdir' from settings and put it in core setting tab #679

Closed kabachuha closed 1 year ago

kabachuha commented 1 year ago

Is there an existing issue for this?

What would your feature do ?

It doesn't make sense to leave it in the settings file, since it is different for each user and can break the launches without users correcting it manually. And it can carry sensitive information, such as a user's true username, system and folder structure.

Proposed workflow

  1. Go to Settings tab, setup your outdir and never touch it again

Additional information

No response

Are you going to help adding it?

Yes

hithereai commented 1 year ago

This is not a good idea as you present it - users change this field lots of times a day, putting it in the general settings is just asking for trouble.

I never actually saw a user failing to generate a video because of the batch_name param... Did you?

hithereai commented 1 year ago

Handled in https://github.com/deforum-art/sd-webui-deforum/pull/680