Open brbbbq opened 1 year ago
This issue has been closed due to incorrect formatting. Please address the following mistakes and reopen the issue (click on the 'Reopen' button below):
@reallybigname would appreciate your input
This issue has been closed due to incorrect formatting. Please address the following mistakes and reopen the issue (click on the 'Reopen' button below):
Tried to fix the "wrong format" error by adding the cmd console logs, but there's no "Reopen" button available.
Thanks for addressing your formatting mistakes. The issue has been reopened now.
Planning to test this very soon.
I've actually been doing more testing and finding some inconsistencies with my results. I'm in the middle of trying to isolate some things, will follow up soon.
I've discovered 2 separate issues with using resume with cadence that seem to require 2 separate solutions. I used a cadence of 6, and a seed travel of 0.01/frame (I used Parseq to animate the seed).
CASE 1 - 3D Translation Only When stopping at frame 59, and resuming it creates a stutter (repeats the last 6 frames). The best solution I've found so far is to remove the last 6 frames and save in a separate folder, then resume from frame 53.
In After Effects, cut the sequence at frame 60, then slide the end section -6 frames to frame 54, overlay the saved 6 frame sequence at frame 54, and fade out (this is the same process outlined in the original post). https://i.imgur.com/xxON9h1.mp4
CASE 2 - 3D Translation & Rotation I'm not sure exactly what's going on, but for some reason the above solution doesn't work when the animation includes 3D rotation. When sliding the resumed sequence -6 frames, it makes it worse. It seems like instead of a stutter (repeating frames) it's doing the opposite (skipping frames).
In this case resuming at frame 53 achieved best results, I think this is simply from the movement being smaller at frame 53 than frame 59. https://i.imgur.com/THEQqzW.mp4
I don't know if there's some difference in the order of operations with 3D rotation that makes the scenario different than animating only the translation, but as far as I can tell animating translation creates a stutter (repeat frames) whereas rotation causes skip frames.
Don't know if this is helpful or not, but here's a link to my AE project files if you're interested in referring to it at all: https://mega.nz/file/sT8niTqD#2l5EtMdSV40HTIL2s1wj747_A6NPMT9xnAywmUEXCq4
Don't know if this is helpful or not, but here's a link to my AE project files if you're interested in referring to it at all: https://mega.nz/file/sT8niTqD#2l5EtMdSV40HTIL2s1wj747_A6NPMT9xnAywmUEXCq4
Not at all interested! But, thanks for alerting me to the resume issue. I was able to fix it last time without After Effects, so I'm sure I'll be fine this time. lol
I have repaired a bunch of stuff in my local copy. Within the next few days I should have a PR that fixes resume as well as fixing an issue where it won't go all the way to the end of an animation, and adding a bunch of new features and making others better.
Sorry I never fixed this. I got totally messed up by a health issue and couldn't do anything for over a month. However, I'm catching up now and have many changes to incorporate, including a rock solid fix for this which is working locally.
I may have had it done before I became ill, but when I went to fix it I found other issues that had cropped up in recent updates that made fixing it by itself much harder. Indexing was all one-off and actually had to change a lot of code to make it work right. Also, the current version won't go to the end frame of an animation. I guess nobody noticed! It was cutting of early. I don't know if I'll just try to merge everything in a nightmare merge, or address each issue separately using my copy as a reference, but either way I'm back on the job and eager to finish.
I've resumed now from many different scenarios including optical flow cadences and haven't had one issue. It's looking good. I also added a variable resume_skip_cadence which skips the cadence cycle, making the logic around resuming much easier to understand. The cadence loop comes before generation in the code, using two images from the previous cycles. So, this skipping also allows it to only regenerate the very last actual generation, rather than having to start back an extra cycle. I really got down to the nitty gritty. It starts right into the rerender of the last actual generated frame, then continues the cadence as normal.
I could have started right into the next frame without a skip mechanism, but the last generation, and the cadence frames leading up to it, usually need regenerating anyway if you cancelled, since the generation can get stopped right in the middle with a corrupted image. So, last time I fixed it, I had to make it go back another cycle in order to ensure redoing corrupted frames. The way I did it now seems to always work, and I think it could even resume from a single done image, though I haven't tried that.
No worries, totally know the feeling, been dealing with fatigue related to a medical condition myself.
Really appreciate you taking the time to follow-up on it, look forward to seeing it in an update!
HI guys! Thanks for putting up this issue and working to solve it. I am also very keen on a solution to this as I use the resume feature a lot. It's nice to just step forward around 50 frames at a time, deciding what to do along the way, as it can be quite unpredictable how an animation develops. Currently I'm postponing creating anything new because of this issue. Don't really feel like going through the hassle of using video editing software to address this at like 20 different points in a 3 minute animation.,
Have you read the latest version of the FAQ?
Is there an existing issue for this?
Are you using the latest version of the Deforum extension?
What happened?
When using the resume function with cadence, it blends the resumed frames at the incorrect location on the timeline. In the following example cadence is set to 12 to highlight the issue. You can see the stutter at frames 72-84 on the left. The right side is after manually fixing the issue in After Effects:
https://github.com/deforum-art/sd-webui-deforum/assets/135537138/99ad723c-3538-4a80-a734-5163c801a0c0
With the current resume function, at frames 72-84, the resumed frames are inserted one period (12 frames) late, causing the animation to look like it's repeating the motion (stutter).
Steps to reproduce the problem
Using the current resume function in the Deforum extension for Automatic1111
What should have happened/how would you fix it?
I was able to fix the problem manually by the following steps:
Torch version
torch: 1.13.1+cu117
On which platform are you launching the webui with the extension?
No response
Deforum settings
https://gist.github.com/brbbbq/e31caa7054ece9e5ed2b17830e3c0fb4
Webui core settings
https://gist.github.com/brbbbq/39dbb20632274751357cac5a2e38ef13
Console logs
Additional information
No response