search

defrex / hs-proxy

hipsell.com
1 stars 0 forks source link

Misc #1

Open shz opened 13 years ago

shz commented 13 years ago

Two things.

  1. We have a naming issue. I've been using hs-proxy for the websocket proxy. Perhaps we should just merge these two.
  2. https://github.com/nodejitsu/node-http-proxy may be a better solution than rolling our own
hipsell-robot commented 13 years ago

You're right about the naming thing. I just couldn't see your repo when I created mine. I'm not sure about merging. Take a look at my code, it's not doing very much. A simple mapping between hostnames and local ports. Basically just replacing what we use nginx for right now.

As to node-http-proxy, I thought it's be just as easy to do it with plain node, but I'm running into a weird crash occasionally on the server, and always when proxying to django. Maybe using a pre-made lib is a good idea.

Aron

On Sun, May 29, 2011 at 2:58 PM, shz < reply@reply.github.com>wrote:

Two things.

  1. We have a naming issue. I've been using hs-proxy for the websocket proxy. Perhaps we should just merge these two.
  2. https://github.com/nodejitsu/node-http-proxy may be a better solution than rolling our own

Reply to this email directly or view it on GitHub: https://github.com/defrex/hs-proxy/issues/1

shz commented 13 years ago

Websockets violate HTTP in the current spec, and looking at the current implementation the proxy isn't complaint with the spec, so that probably explains both of those. The devil is in the details... On May 29, 2011 3:06 PM, "hipsell-robot" < reply@reply.github.com> wrote:

You're right about the naming thing. I just couldn't see your repo when I created mine. I'm not sure about merging. Take a look at my code, it's not doing very much. A simple mapping between hostnames and local ports. Basically just replacing what we use nginx for right now.

As to node-http-proxy, I thought it's be just as easy to do it with plain node, but I'm running into a weird crash occasionally on the server, and always when proxying to django. Maybe using a pre-made lib is a good idea.

Aron

On Sun, May 29, 2011 at 2:58 PM, shz < reply@reply.github.com>wrote:

Two things.

  1. We have a naming issue. I've been using hs-proxy for the websocket proxy. Perhaps we should just merge these two.
  2. https://github.com/nodejitsu/node-http-proxy may be a better solution than rolling our own

Reply to this email directly or view it on GitHub: https://github.com/defrex/hs-proxy/issues/1

Reply to this email directly or view it on GitHub: https://github.com/defrex/hs-proxy/issues/1#comment_1257849