Open andrey-helldar opened 3 hours ago
@fabio-ivona, @MarioGattolla, I've poured in improvements and fixes 🤗
@fabio-ivona I think the change of variable from array to collection (newReaction , oldReaction) could be a breaking change. Let me know if I'm wrong
@fabio-ivona I think the change of variable from array to collection (newReaction , oldReaction) could be a breaking change. Let me know if I'm wrong
confirm a BC here, @andrey-helldar could you fix?
@MarioGattolla, I was thinking the same thing and didn't expect the previous changes to be released so soon.
But the hope was that the fix would fly in so fast that hardly anyone would notice it :)
@fabio-ivona I can. Let's be more specific: you need to remove collections and return an array?
Also, I created a new data object there called ReactionType. Do I delete it too or can I make an array_map for it?
The following changes have been made:
messageReaction()
method to theTelegramUpdate
objectReaction
andReactionType
to the documentationReaction
object now contains a collection ofReactionType
objects rather than an array (added after a similar comment)ReactionType
objecthandleChatReaction
method of theWebhookHandler
class, changed the typing of the$newReactions
and$oldReactions
parameters toCollection
instead ofarray
.I apologize for this omission. I noticed it only now 😅
Why are all these changes all in one PR? It's simple! The code to be fixed is firmly bound to its "neighbor" and it's pointless, in my opinion, to create separate PRs that will load each other.