search

defstudio / vite-livewire-plugin

Laravel Vite handler for Livewire components
MIT License
259 stars 7 forks source link

Adds Vite 5 support #99

Closed BALOTIAS closed 5 months ago

BALOTIAS commented 5 months ago

Aloha! 🌺 I just did some virtual hula dancing to add Vite 5 support. I've thrown it in there like confetti at a beach party. Take a peek and give it a whirl! Test it out, and fingers crossed, it should be smoother than a surfing penguin. 🐧🏄‍♂️ Let me know how it grooves! 🤙

Had to add skipLibCheck to tsconfig.json because of:

Looks like the type definitions from Vite 5 are doing the Macarena when they should be doing the Cha-Cha. Can you figure out the dance floor drama? Maybe they're just having a wild party and need a sober code enforcer. Any insights on their dance moves? 💃🕺 Let me know if you can help me make sense of this dance-off! 🕵️‍♂️🎉

fabio-ivona commented 5 months ago

+1 for the PR text :rofl:

thanks @BALOTIAS for your work :heart:

could you just check if we can make node 14.x tests pass or we should tag a new major version dropping its support?

BALOTIAS commented 5 months ago

@fabio-ivona :)) Vite 5 dropped support for old Nodejs versions, so 18, 20+ is required... see: https://vitejs.dev/blog/announcing-vite5#node-js-support

fabio-ivona commented 5 months ago

@BALOTIAS I've tagged 2.0.0-alpha.2

would you mind to help me with some test before issuing with a stable release?

BALOTIAS commented 5 months ago

Sure, what exactly would you like to test?

fabio-ivona commented 4 months ago

Just if all works smoothly on your projects, in case there are some edge cases that aren't covered

mikewink commented 4 months ago

I installed the alpha 2 in a project and so far, it all works as expected, or how I used to work with the plugin before. As I will work on the Livewire project all week long, I will have plenty of hours to test.

fabio-ivona commented 4 months ago

Ok, I'm planning a stable release on next week, so we can fully test it. Thanks!

mikewink commented 4 months ago

I used the plugin in every day for several hours the last week. I had zero problems with it. It just works.

I am running it inside a DDEV container, where the Vite config is a bit different from regular Laravel, and it still works.

fabio-ivona commented 4 months ago

@mikewink thanks for your feedback ❤️