Closed calvinmetcalf closed 8 years ago
Any way to get a test for this?
not without more info for how it's actually breaking in IE
LGTM, feel free to merge.
I also added you as a collaborator on the project. Feel free to tackle anything without waiting on me if I am blocking. I think you know the main goals here: avoid bloat, and be careful. We don't need to get too creative here as this stuff has been pretty battle tested by now I think and we can focus on incremental fixes.
thanks!
We recently ran into this issue as well. Do you mind publishing a new release to npm?
Thanks!
@calvinmetcalf do you know the process to publish?
i assume it's npm version followed by npm publish
On Sat, May 7, 2016 at 11:19 AM Roman Shtylman notifications@github.com wrote:
@calvinmetcalf https://github.com/calvinmetcalf do you know the process to publish?
— You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub https://github.com/defunctzombie/node-process/pull/57#issuecomment-217643733
Yep. 👍 What is your npm username?
cwmma
On Sat, May 7, 2016 at 1:22 PM Roman Shtylman notifications@github.com wrote:
Yep. 👍 What is your npm username?
— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/defunctzombie/node-process/pull/57#issuecomment-217653219
@calvinmetcalf added as owner. You should be able to publish as needed now. I think you understand the spirit of the project but if you are unsure feel free to ping me about updates :)
done
@calvinmetcalf @defunctzombie Thanks for the quick turn-around!
@chrisradek any change you could help the edge team reproduce https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7206104/
fixes #51 and #56