defunctzombie / node-process

process information for node.js and browsers
MIT License
122 stars 62 forks source link

possible fix for IE weirdness #57

Closed calvinmetcalf closed 8 years ago

calvinmetcalf commented 8 years ago

fixes #51 and #56

defunctzombie commented 8 years ago

Any way to get a test for this?

calvinmetcalf commented 8 years ago

not without more info for how it's actually breaking in IE

defunctzombie commented 8 years ago

LGTM, feel free to merge.

I also added you as a collaborator on the project. Feel free to tackle anything without waiting on me if I am blocking. I think you know the main goals here: avoid bloat, and be careful. We don't need to get too creative here as this stuff has been pretty battle tested by now I think and we can focus on incremental fixes.

calvinmetcalf commented 8 years ago

thanks!

chrisradek commented 8 years ago

We recently ran into this issue as well. Do you mind publishing a new release to npm?

Thanks!

defunctzombie commented 8 years ago

@calvinmetcalf do you know the process to publish?

calvinmetcalf commented 8 years ago

i assume it's npm version followed by npm publish

On Sat, May 7, 2016 at 11:19 AM Roman Shtylman notifications@github.com wrote:

@calvinmetcalf https://github.com/calvinmetcalf do you know the process to publish?

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/defunctzombie/node-process/pull/57#issuecomment-217643733

defunctzombie commented 8 years ago

Yep. 👍 What is your npm username?

calvinmetcalf commented 8 years ago

cwmma

On Sat, May 7, 2016 at 1:22 PM Roman Shtylman notifications@github.com wrote:

Yep. 👍 What is your npm username?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/defunctzombie/node-process/pull/57#issuecomment-217653219

defunctzombie commented 8 years ago

@calvinmetcalf added as owner. You should be able to publish as needed now. I think you understand the spirit of the project but if you are unsure feel free to ping me about updates :)

calvinmetcalf commented 8 years ago

done

chrisradek commented 8 years ago

@calvinmetcalf @defunctzombie Thanks for the quick turn-around!

calvinmetcalf commented 8 years ago

@chrisradek any change you could help the edge team reproduce https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/7206104/