search

defunctzombie / node-process

process information for node.js and browsers
MIT License
122 stars 62 forks source link

Update event emitter methods #77

Closed feross closed 7 years ago

feross commented 7 years ago
calvinmetcalf commented 7 years ago

removing off could theoretically break stuff, otherwise 👍

dadleyy commented 7 years ago

are there plans to also add a listeners function? jasmine@2.6 was just released and expects it to be defined in node-like environments.

calvinmetcalf commented 7 years ago

@dadleyy good call

calvinmetcalf commented 7 years ago

@feross do you mind updating this if you're able, I can't add to this pull

feross commented 7 years ago

Ah, sorry I already deleted my fork.

What is the best way to add listeners? Should it always return an empty array? Or should we just make process actually inherit from EventEmitter?

calvinmetcalf commented 7 years ago

That's OK I'll just create a new one, empty array sounds right as inheriting is probably a bad idea as it would blow up a lot of code that used process

On Tue, Apr 25, 2017, 5:44 PM Feross Aboukhadijeh notifications@github.com wrote:

Ah, sorry I already deleted my fork.

What is the best way to add listeners? Should it always return an empty array? Or should we just make process actually inherit from EventEmitter?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/defunctzombie/node-process/pull/77#issuecomment-297174415, or mute the thread https://github.com/notifications/unsubscribe-auth/ABE4n0ZUNweWCAD0zW0sRNluGYt_98mRks5rzmlRgaJpZM4NFPwD .

feross commented 7 years ago

Sounds good. Closing this PR then.

calvinmetcalf commented 7 years ago

done published etc