search

defunctzombie / node-required

identifies which modules your script is using
67 stars 15 forks source link

windows issues #17

Open shenanigans opened 9 years ago

shenanigans commented 9 years ago

Currently using required 1.0.0 on windows. Fails 6/12 tests from fresh install. When parsing dependencies for a library that uses mongodb there is a violent reaction.

PARSER\node_modules\required\index.js:147
            throw err;
                  ^
Error: C:\PARSED_PROJECT\node_modules\mongodb\node_modules\bson\ext\win32\x64\bson.node: Line 1: Unexpected token ILLEGAL
    at throwError (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:2159:21)
    at scanPunctuator (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:835:9)
    at advance (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:1496:16)
    at lex (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:1507:21)
    at parsePrimaryExpression (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:2609:13)
    at parseLeftHandSideExpressionAllowCall (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:2755:61)
    at parsePostfixExpression (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:2795:20)
    at parseUnaryExpression (C:\Users\schmidty\Documents\code\node-doczar\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:2825:20)
    at parseBinaryExpression (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:2947:16)
    at parseConditionalExpression (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:2994:16)
    at parseAssignmentExpression (PARSER\node_modules\required\node_modules\detective\node_modules\esprima-fb\esprima.js:3179:16)

edit - currently looking at patching detective

shenanigans commented 9 years ago

Please make this tiny non-breaking change to pass options to detective. I have a pull request to patch detective with a simple change to optionally silence the Error.

defunctzombie commented 8 years ago

PR welcome for the changes needed.