search

defunctzombie / node-url

node.js core url module as a module
MIT License
375 stars 96 forks source link

update to node 7.2.1 #30

Open graingert opened 7 years ago

graingert commented 7 years ago

Fixes #24.

graingert commented 7 years ago

This should be considered wip until there's a babel ES5 build

graingert commented 7 years ago

@defunctzombie I've come up with a slightly nicer way of doing it over at: https://github.com/graingert/browser-libs-node/blob/master/webpack.config.babel.js

This automatically builds a browser safe url module.

defunctzombie commented 7 years ago

@graingert Does that mean this PR is ready for review or is not relevant?

mrtbld commented 7 years ago

This PR is important because it contains two breaking changes that node v7.x introduced :

  1. need to give slashes: true to url.format() to get protocol-relative URLs (node #11103);
  2. automatic // inclusion for file: URLs (node 336b027).

So thank you for this, @graingert!

But I was wondering what still needs to be done to get this merged ? Can I help ?

pho3nixf1re commented 7 years ago

I second that. What is the hold up here and is there anything that can help it along?

ljharb commented 3 years ago

@graingert would you mind checking "allow edits" on the RHS of this PR?

graingert commented 3 years ago

@ljharb done