search

defunctzombie / node-url

node.js core url module as a module
MIT License
375 stars 96 forks source link

Update punycode to 1.4.1 #34

Closed mvasilkov closed 3 years ago

mvasilkov commented 7 years ago

The latest 1.x version of punycode is 1.4.1, it's been out for about a year.

All tests appear to run.

CharlesWall commented 6 years ago

is there a reason not to go to punycode 2.x?

ljharb commented 3 years ago

@CharlesWall yes - punycode v2 requires node v6, so it's unlikely we'll ever be able to upgrade to it.

ljharb commented 3 years ago

(re my extra commit: zuul ran and failed, but it can't run on PRs from forks, because it relies on secrets. Let's see if it passes once it lands on master)