feat: replace depracated query-string with URLSearchParams

defunctzombie / node-url

node.js core url module as a module

MIT License

376 stars 96 forks source link

feat: replace depracated query-string with URLSearchParams #58

Closed martinmunillas closed 3 years ago

martinmunillas commented 3 years ago

querystring is deprecated for the native URLSearchParams API 2021-09-05_13-09 all tests keep passing :D

martinmunillas commented 3 years ago

wouldn't it be better to specify that older versions of node should use previous versions of the package and keep the dependencies up to date for the newer node versions? @ljharb

ljharb commented 3 years ago

No, it wouldn't.

If you know you can use a node with URL and URLSearchParams, why would you be using node's url module in the first place?

Also, don't forget qs exists.

martinmunillas commented 3 years ago

i wouldn't, is a nested dependency, but yeah, i can see your point.