defunctzombie / node-url

node.js core url module as a module
MIT License
375 stars 96 forks source link

Replace querystring with qs #62

Closed vramana closed 1 year ago

vramana commented 1 year ago

Ref: https://github.com/defunctzombie/node-url/issues/57#issuecomment-1264684185

codecov-commenter commented 1 year ago

Codecov Report

Base: 97.00% // Head: 97.00% // No change to project coverage :thumbsup:

Coverage data is based on head (aa81cae) compared to base (5480ec0). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #62 +/- ## ======================================= Coverage 97.00% 97.00% ======================================= Files 1 1 Lines 367 367 Branches 133 133 ======================================= Hits 356 356 Misses 11 11 ``` | [Impacted Files](https://codecov.io/gh/defunctzombie/node-url/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [url.js](https://codecov.io/gh/defunctzombie/node-url/pull/62?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-dXJsLmpz) | `97.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

vramana commented 1 year ago

@ljharb It seems 0.6 version fails while compiling node itself if I understand correctly.

ljharb commented 1 year ago

yes, you don’t have to worry about that.

vramana commented 1 year ago

@ljharb Fixed conflicts and pushed changes again

vramana commented 1 year ago

@ljharb Ping