search

defunctzombie / npm-css

Require css from npm
MIT License
128 stars 8 forks source link

why do you use cssp? why not rework? #10

Open jonathanong opened 10 years ago

jonathanong commented 10 years ago

it's all in russian. i don't know what's going on.

defunctzombie commented 10 years ago

I think this was before rework existed? Or maybe before I knew about rework. Happy to change it if it functions the same! On Dec 16, 2013 4:02 AM, "Jonathan Ong" notifications@github.com wrote:

it's all in russian. i don't know what's going on.

— Reply to this email directly or view it on GitHubhttps://github.com/defunctzombie/npm-css/issues/10 .

defunctzombie commented 10 years ago

I also found this: https://github.com/conradz/rework-npm

The main difference is that npm-css auto-prefixes based on module to avoid leaking, but maybe that is too opinionated.

Raynos commented 10 years ago

@jonathanong cssp is used because i couldnt find any decent CSS parsers and substack has used cssp in the past. If its good enough for substack, its good enough for me.

Also most CSS parsers DO NOT PARSE COMMENTS. cssp does.

Last time I checked rework does not parse comments.

A previous version of npm-css used // @require 'foo'

jonathanong commented 10 years ago

Yeah it parses comments. It doesn't keep formatting exact though.

defunctzombie commented 10 years ago

We don't need comment parsing anymore, but we do need the preserve the auto-prefix feature. Maybe I will just make a rework module that uses rework-npm and then does the prefixing as an option :/

defunctzombie commented 10 years ago

We can probably use this module: https://github.com/conradz/rework-npm