search

defunctzombie / npm-css

Require css from npm
MIT License
128 stars 8 forks source link

Only import a module's stylesheet the first time a module is seen in the tree. #8

Closed techwraith closed 11 years ago

techwraith commented 11 years ago

This is just a start, I'll be adding tests and trying to break it later this week. I just wanted to start the conversation early to make sure I'm going in a good direction.

techwraith commented 11 years ago

Also, just for reference, I'll leave this here:

solves #6

techwraith commented 11 years ago

Any thoughts on this one?

techwraith commented 11 years ago

Just pushed an update that I think will be the final one, unless you can think of a way to remove the @import statements that are duplicates...

techwraith commented 11 years ago

How is that?

defunctzombie commented 11 years ago

Looks, good. Can we add a test for this?

techwraith commented 11 years ago

Sure, what do I need to do to get the tests to run? I get not ok 2 Error: Cannot find module 'foobar' right now when I run them.

defunctzombie commented 11 years ago

I'll take a look. Been a while since I poked at it :) On Aug 7, 2013 6:31 PM, "Daniel Erickson" notifications@github.com wrote:

Sure, what do I need to do to get the tests to run? I get not ok 2 Error: Cannot find module 'foobar' right now when I run them.

— Reply to this email directly or view it on GitHubhttps://github.com/shtylman/npm-css/pull/8#issuecomment-22296806 .

techwraith commented 11 years ago

Also, should we comment out the duplicate @import statements? If so, any advice on doing so?

techwraith commented 11 years ago

Any progress on this?

techwraith commented 11 years ago

One more bump.

defunctzombie commented 11 years ago

I haven't forgotten about this, just been preoccupied with other things.

techwraith commented 11 years ago

No problem, I'm just making sure ;)

We're waiting on this pull request before we put this into production at work.

On Wednesday, August 21, 2013, Roman Shtylman wrote:

I haven't forgotten about this, just been preoccupied with other things.

— Reply to this email directly or view it on GitHubhttps://github.com/shtylman/npm-css/pull/8#issuecomment-23003145 .

techwraith commented 11 years ago

Awesome, thanks for this! I've updated atomify to reflect this. Now all of our CSS can name it's own deps and all is right with the world :)