search

defunctzombie / zuul

[UNMAINTAINED] multi-framework javascript browser testing
957 stars 87 forks source link

Exception not handled about open_tunnel.url #169

Closed MoOx closed 9 years ago

MoOx commented 9 years ago

Not sure what I changed recently (just a few lines) and I am getting this

$ zuul -- dist/test.js

- testing: chrome @ Windows 2012 R2: 39 40

/.../node_modules/zuul/node_modules/zuul-localtunnel/index.js:22
    var url = open_tunnel.url + '/__zuul';
                         ^
/.../node_modules/zuul/node_modules/zuul-localtunnel/index.js:22:26,/.../node_modules/zuul/node_modules/zuul-localtunnel/node_modules/localtunnel/client.js:312:20,/.../node_modules/zuul/node_modules/zuul-localtunnel/node_modules/localtunnel/client.js:283:20,Request._callback (/.../node_modules/zuul/node_modules/zuul-localtunnel/node_modules/localtunnel/client.js:206:24),Request.self.callback (/.../node_modules/zuul/node_modules/zuul-localtunnel/node_modules/localtunnel/node_modules/request/main.js:122:22),Request.emit (events.js:110:17),Request.<anonymous> (/.../node_modules/zuul/node_modules/zuul-localtunnel/node_modules/localtunnel/node_modules/request/main.js:655:16),Request.emit (events.js:129:20)

This doesn't help a lot :/

rase- commented 9 years ago

This exception is highly unexpected, so I doubt it should be handled. Do you have local changes to Zuul itself? Or just configuration / the tests?

rase- commented 9 years ago

Hmm the issue itself looks like for some reason localtunnel is unable to open a tunnel.

MoOx commented 9 years ago

I just get the same issue on travis :/ (so fresh zuul module)

rase- commented 9 years ago

@MoOx ok that just happened to me too. I think there's something wrong with localtunnel.

cc @defunctzombie

rase- commented 9 years ago

Without making any changes that is.

MoOx commented 9 years ago

Good to know the issue is not just for me. But ouch.

screen shot 2015-03-03 at 16 12 01

So I am guessing this case should be handled :(

rase- commented 9 years ago

Should probably be handled in the localtunnel module though.

MoOx commented 9 years ago

zuul-localtunnel, sure.

rase- commented 9 years ago

Now has a better error since https://github.com/defunctzombie/zuul/commit/583190205e40ec2c8ced79b7ee6944ff65f5d9b0

Thanks @MoOx!

rase- commented 9 years ago

You'll see

Error: localtunnel server returned an error, please try again

from now on.

rase- commented 9 years ago

@MoOx looks like lt is back! :)

MoOx commented 9 years ago

I just pinged the interested person on twitter ;)