IE6 IE7 : Blocking js error in client.js

defunctzombie / zuul

[UNMAINTAINED] multi-framework javascript browser testing

958 stars 87 forks source link

IE6 IE7 : Blocking js error in client.js #223

Open sylvaincombes opened 9 years ago

sylvaincombes commented 9 years ago

Hi there is some js code that block my tests in ie6 and ie7 (stuck on white page) , see attached screenshots :

ie6_ie7_ie_error

ie6_ie7_ie_error_location

I use the 3.2.0 release.

Would be great if you can correct this ;)

Thank you for your work

defunctzombie commented 9 years ago

Do you know what the specific problem is? Can you make a patch since you are able to reproduce?

sylvaincombes commented 9 years ago

Hi, I have looked at this problem quickly last night :

I think the error raised by ie6 and ie7 is the trailing comma on the line _labeltodo:
```
label_todo: /^(.*?)\s*#\s*TODO\s+(.*)$/,
```

since ie6 and ie7 doesn't play well with this kind of syntax

I suppose this code come from an external dependency used in zuul : tap-parser
zuul seems to use the version 0.7.0 : https://github.com/substack/tap-parser/tree/b80725adc41e9ce88a3a90fac5bc4e714fa8be9f

What is weird is that the file doesn't have this comma in source code : https://github.com/substack/tap-parser/blob/b80725adc41e9ce88a3a90fac5bc4e714fa8be9f/index.js#L13

But when executed in ie via "client.js" it does have it.

I don't have more clue to help resolving this problem maybe you have ?

sylvaincombes commented 9 years ago

Oh I think I found more info, in fact it's the zuul dependency tap-finished who itself requires tap-parser in version 0.2.0 and in this version the comma is here see it here : https://github.com/substack/tap-parser/blob/bfea7c4e273fbd694940a755f73b9781cd57c047/index.js#L14

So maybe the solution is to ask on the repository https://github.com/substack/tap-finished to require the version 0.7.0 of tap-parser and after that update the zuul package.json to the updated version of tap-finished

sylvaincombes commented 9 years ago

I have open an issue here : https://github.com/substack/tap-finished/issues/5

I guess we have to wait and see for now

defunctzombie commented 9 years ago

@vvo with the recent tap changes can we stop using tap-finished?

vvo commented 9 years ago

@vvo with the recent tap changes can we stop using tap-finished?

Not sure, last time I tried it was still not working. You mean changes in tap-parser?

@sylvaincombes You can still try to remove tap-finished and use only tap-parser, there are some tests that should fail if it's not working.

sylvaincombes commented 9 years ago

I tried your suggestion @vvo but it seems that tests fails if we remove this dependency