search

defunctzombie / zuul

[UNMAINTAINED] multi-framework javascript browser testing
958 stars 87 forks source link

Add SauceLabs tags for branch/SHA data #301

Closed shaungrady closed 4 years ago

shaungrady commented 8 years ago

Add current branch name and last commit short SHA as SauceLabs session tags.

mention-bot commented 8 years ago

@shaungrady, thanks for your PR! By analyzing the annotation information on this pull request, we identified @defunctzombie, @vvo and @JamesKyburz to be potential reviewers

shaungrady commented 8 years ago

Not sure what happened to Travis on that last build attempt... network issues trying to download the Phantom binary?

shaungrady commented 8 years ago

Reverted .travis.yml, am forced to use an async method to getting git branch and commit SHA data. It's a fast command that should complete before the browser method is called (and does in my limited testing), but it's not ideal. Worst case is that the child process doesn't close before browser is called, in which case, no branch/SHA data is added to the tags property.