defunctzombie / zuul

[UNMAINTAINED] multi-framework javascript browser testing
958 stars 87 forks source link

feat: Added --no-instrument option. #310

Closed shannonmoeller closed 7 years ago

shannonmoeller commented 7 years ago

This PR implements a --no-instrument configuration flag. This is useful when coverage is desired, but instrumentation happens at a different point in the pipeline; such as using babel-plugin-istanbul. This is how nyc solves the same issue.

Example use case: https://github.com/shannonmoeller/babel-browserify-nyc-tape-zuul-isomorphic-demo

mention-bot commented 7 years ago

@shannonmoeller, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rase-, @defunctzombie and @vvo to be potential reviewers.

defunctzombie commented 7 years ago

LGTM

@vvo thoughts?

vvo commented 7 years ago

LGTM too, plain simple :)

shannonmoeller commented 7 years ago

Thank you!

shannonmoeller commented 7 years ago

Is a release planned for any time soon?

vvo commented 7 years ago

@shannonmoeller Actually there's no motivated maintainer for this project nowadays. We are looking for a new maintainer. Responsibilities:

Are you willing to do something like that?

shannonmoeller commented 7 years ago

I'd have to think about that. I really appreciate zuul as a tool, and VASTLY prefer it to the likes of Karma, but not being familiar with the ins-and-outs of the internals makes me wary to sign up.

Where did the momentum go (really hoping you don't say webpack)?

vvo commented 7 years ago

Nowadays I am mostly doing tests with jest and fine with it for most libraries. Making unit test pass on X browsers is not something I recommend anymore. Most of the failures I had with things like karma and zuul where due to the complexity of such programs, not from my own code.

Then I write integration testing with webdriver.io.

defunctzombie commented 7 years ago

On my end, I am just not actively doing frontend day to day anymore and so don't find time to carve out for maintaining this as it needs to be.