Stop using http tarball for stacktrace-js

defunctzombie / zuul

[UNMAINTAINED] multi-framework javascript browser testing

958 stars 87 forks source link

Stop using http tarball for stacktrace-js #317

Closed vvo closed 7 years ago

vvo commented 7 years ago

@defunctzombie I cannot recall why we where linking to your own stacktrace version, what did it fixed that is not fixed inside the original module?

The thing is that right now with yarn I have issues installing zuul, haven't dig into it. I am just almost sure this will solve it.

mention-bot commented 7 years ago

@vvo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mcollina, @defunctzombie and @bevacqua to be potential reviewers.

mcollina commented 7 years ago

Definitely LGTM :)

defunctzombie commented 7 years ago

There was certainly a reason for it when I did it. The repo history for the fork might have some commits that indicate why. If it works on upstream now 👍

defunctzombie commented 7 years ago

https://github.com/defunctzombie/stacktrace.js/commit/07e7b9516f1449f5c209e4f67f11a43f738c1712

Seems to be related to detecting phantomjs