search

defunkt / cijoe

CI Joe is a fun Continuous Integration server. Unmaintained.
MIT License
1.05k stars 129 forks source link

Rescue from YAML and fix build status. #46

Closed febuiles closed 13 years ago

febuiles commented 13 years ago

Rescue from YAML: In Ruby 1.9.2 YAML will fail with ArgumentError: syntax error on line 0, col 132 when it receives the Github post-receive POST. This should fix it.

I also noticed that the build fields are updated in CIJoe#build! in an instance variable but they're never assigned back to @current_build. Stuff like the Campfire notifier needs this information to post the log in the chat so I just copied it back.

febuiles commented 13 years ago

Added a second fix for Ruby 1.9.

queso commented 13 years ago

febuiles,

Do you know why this was closed or how did you fix it? I am getting the same issue under ruby 1.8.7 REE.

febuiles commented 13 years ago

I closed it and created another one to split it in 2 requests. The YAML one should be up later :)

queso commented 13 years ago

febuiles,

Be sure to test hitting the build button by hand, I am seeing errors with an empty post and your solution.

febuiles commented 13 years ago

queso: If you change your server.rb to https://gist.github.com/815685 it should work. I'm trying to find a cleaner solution that works in 1.8 and 1.9.