defunkt / gist.el

Yet another Emacs paste mode, this one for Gist.
548 stars 90 forks source link

Storing passwords in plaintext?? #84

Closed siassaj closed 7 years ago

siassaj commented 8 years ago

So i just used this to successfully make a gist, but it appears to have saved my password in plaintext in ~/.gitconfig.

Is this correct?

Olivia5k commented 8 years ago

I just saw this as well. However, since neither password, pass or config appear in the source it could be that it is some underlying library that causes this.

EDIT: Wasn't hard to find the culprit: https://github.com/sigma/gh.el/blob/master/gh-auth.el#L63-L73

Olivia5k commented 8 years ago

Submitted to upstream plugin.

sigma commented 7 years ago

should be fixed now