Add option for ask for file name

defunkt / gist.el

Yet another Emacs paste mode, this one for Gist.

550 stars 90 forks source link

Add option for ask for file name #98

Closed marcelino-m closed 7 years ago

marcelino-m commented 7 years ago

Add defcustom gist-ask-for-filename
Add function gist-ask-for-filename-maybe
Modify function gist-region

sigma commented 7 years ago

That looks good, but would you mind renaming those to follow the more popular pattern "prompt-for" ? That'd be more consistent with the rest of the ecosystem.

Thanks !

marcelino-m commented 7 years ago

Do you mean like this:

gist-ask-for-filename -> gist-prompt-for-filename
gist-ask-for-filename-maybe -> gist-prompt-for-filename-maybe

For me it's no problem, but in gist.el exist:

gist-ask-for-description
gist-ask-for-description-maybe

Then for consistency I did it this way. So , What do you think, I change my pull request?

I wait for you feedback, Regards!

sigma commented 7 years ago

arg, you're right (I wish I had paid more attention when that code got merged). Alright, let's go with this scheme then. Thanks !